Add getscom support for odyssey chipunit #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakala-k
force-pushed
the
chipunit_getscom
branch
3 times, most recently
from
a705c6b
to
badd02f
Compare
devenrao
reviewed
Jan 11, 2024
devenrao
suggested changes
Jan 11, 2024
Added the translation required for the odyssey chipunit like memport. With this change, the getscom and the putscom support for odyssey chipunits shall work as expected. Tested and Working as expected. root@p10bmc:/tmp# putscom odyssey c0002040 -p2 deadbeefdeadbeef odyssey k0:n0:s0:p02 /usr/bin/edbg putscom odyssey c0002040 -p2 deadbeefdeadbeef root@p10bmc:/tmp# getscom odyssey c0002040 -all odyssey k0:n0:s0:p02 0xDEADBEEFDEADBEEF odyssey k0:n0:s0:p03 0x004011000A000640 odyssey k0:n0:s0:p34 0x004011000A000640 odyssey k0:n0:s0:p35 0x004011000A000640 /usr/bin/edbg getscom odyssey c0002040 -all root@p10bmc:/tmp# putscom odyssey c0002040 -p2 004011000A000640 odyssey k0:n0:s0:p02 /usr/bin/edbg putscom odyssey c0002040 -p2 004011000A000640 root@p10bmc:/tmp# getscom odyssey c0002040 -all odyssey k0:n0:s0:p02 0x004011000A000640 odyssey k0:n0:s0:p03 0x004011000A000640 odyssey k0:n0:s0:p34 0x004011000A000640 odyssey k0:n0:s0:p35 0x004011000A000640 /usr/bin/edbg getscom odyssey c0002040 -all Signed-off-by: Deepa Karthikeyan <[email protected]>
deepakala-k
force-pushed
the
chipunit_getscom
branch
from
badd02f
to
28abe44
Compare
aravynd
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the translation required for the odyssey chipunit like memport. With this change, the getscom and the putscom support for odyssey chipunits shall work as expected.
Tested and Working as expected.