Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change required scope of entrypoint from rule to document #6963

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Change required scope of entrypoint from rule to document #6963

merged 1 commit into from
Aug 28, 2024

Commits on Aug 28, 2024

  1. Change required scope of entrypoint from rule to document 

    And automatically change implied `scope` from `rule` to `document` when
no `scope` is provided (on rule metadata).

Whether this can be included in a "normal" release, or will have to wait
until OPA 1.0, I'll let others decide. But I think it's worth pointing out
that this is a breaking change to address a **bug**, and that a scope of
`rule` makes no sense for an entrypoint.

One alternative could perhaps be to only change this behavior when
`import rego.v1` is included in a file, as that's meant to be a glimpse
of the future anyway. But at this time, no such considerations have been
taken.

Fixes open-policy-agent#6798

Signed-off-by: Anders Eknert <[email protected]>
    @anderseknert
    anderseknert committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    8b558a1 View commit details
    Browse the repository at this point in the history