tracing: make otel dependency optional for rego+topdown#4127
Merged
srenatus merged 5 commits intoopen-policy-agent:mainfrom Dec 14, 2021
Merged
tracing: make otel dependency optional for rego+topdown#4127srenatus merged 5 commits intoopen-policy-agent:mainfrom
srenatus merged 5 commits intoopen-policy-agent:mainfrom
Conversation
srenatus
force-pushed
the
sr/otel/make-dep-optional
branch
2 times, most recently
from
d215fb0 to
5eda605
Compare
This follows the same approach as the wasm feature: by default, importers
of
github.com/open-policy-agent/opa/rego
github.com/open-policy-agent/opa/topdown
will not get a transitive dependency on the otel libraries.
In terms of functionality, nothing changes for the server and runtime.
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/otel/make-dep-optional
branch
from
5eda605 to
1e8b983
Compare
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/otel/make-dep-optional
branch
from
1e8b983 to
e186d6e
Compare
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
tsandall
previously approved these changes
Dec 13, 2021
Member
tsandall
left a comment
tsandall
left a comment
There was a problem hiding this comment.
LGTM. Must be a law of software development that as a project ages it eventually imports every logging library in existence.
| tracing = ht | ||
| } | ||
|
|
||
| func NewTransport(tr http.RoundTripper, opts Options) http.RoundTripper { |
Member
There was a problem hiding this comment.
nit: missing docstrings on these exported functions. I'm surprised that golangci isn't catching this.
Contributor
Author
There was a problem hiding this comment.
Hmm maybe it picks up that it's used by implementing an interface? Interface implementations might not need their own comments...? 🤔
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the same approach as the wasm feature: by default, importers
of
will not get a transitive dependency on the otel libraries.
In terms of functionality, nothing changes for the server and runtime.
Follow-up to #4029, discussed on that PR.