actions: fix e2e test, add it to pull-request workflow#222
Merged
ashutosh-narkar merged 1 commit intoopen-policy-agent:masterfrom Nov 30, 2020
Merged
actions: fix e2e test, add it to pull-request workflow#222ashutosh-narkar merged 1 commit intoopen-policy-agent:masterfrom
ashutosh-narkar merged 1 commit intoopen-policy-agent:masterfrom
Conversation
srenatus
force-pushed
the
sr/fix-e2e-action
branch
5 times, most recently
from
82f7104 to
a60717d
Compare
srenatus
changed the title
| @@ -55,44 +55,3 @@ jobs: | |||
| # Only run if required secrets are provided | |||
| if: ${{ env.DOCKER_USER && env.DOCKER_PASSWORD }} | |||
| run: make deploy-ci | |||
Member
There was a problem hiding this comment.
Any reason for removing the e2e on master ? Even though we run it on a PR, it would fine to run it on master as well imo.
Collaborator
Author
There was a problem hiding this comment.
Hmm good point. We can have both. I'll restore them.
Collaborator
Author
There was a problem hiding this comment.
Updated, it's running twice now. Slightly refactored the actions in the process.
srenatus
force-pushed
the
sr/fix-e2e-action
branch
from
76ccf38 to
93da5d7
Compare
Also updates kind to 0.9.0, required for Istio 1.7.0. (Oversight of open-policy-agent#217) Signed-off-by: Stephan Renatus <stephan@styra.com>
srenatus
force-pushed
the
sr/fix-e2e-action
branch
from
93da5d7 to
058407b
Compare
srenatus
changed the title
srenatus
commented
Nov 26, 2020
| cd /tmp/istio-${ISTIO_VERSION} | ||
| pushd /tmp/istio-${ISTIO_VERSION} | ||
| bin/istioctl install -y --set profile=demo | ||
| popd |
Collaborator
Author
There was a problem hiding this comment.
This cd to pushd change doesn't really matter for the script, but it also doesn't hurt...
Collaborator
Author
|
✔️ looks OK here: https://github.com/open-policy-agent/opa-envoy-plugin/runs/1475406622 Thanks for the review 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates kind to 0.9.0, required for Istio 1.7.0.
(Oversight of #217)
👉 Here's an example run of this PR: https://github.com/open-policy-agent/opa-envoy-plugin/runs/1453090996?check_suite_focus=true#step:4:211
⏱️ Just short of 5 minutes. Sounds OK to me. Let's try to roll with this in the pull-request workflow for a while.