Skip to content

chore: removing wait of vapb deletion, cherry-pick (#3718)#3724

Merged
JaydipGabani merged 1 commit into
open-policy-agent:release-3.18from
JaydipGabani:release-3.18
Dec 5, 2024
Merged

chore: removing wait of vapb deletion, cherry-pick (#3718)#3724
JaydipGabani merged 1 commit into
open-policy-agent:release-3.18from
JaydipGabani:release-3.18

Conversation

@JaydipGabani
Copy link
Copy Markdown
Contributor

Signed-off-by: Jaydip Gabani gabanijaydip@gmail.com
(cherry picked from commit 9a85a21)

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
(cherry picked from commit 9a85a21)
@JaydipGabani JaydipGabani requested a review from a team as a code owner December 4, 2024 22:18
@JaydipGabani JaydipGabani requested a review from Copilot December 4, 2024 22:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • test/bats/helpers.bash: Language not supported
  • test/bats/test.bats: Language not supported

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-3.18@516fb3b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...onstrainttemplate/constrainttemplate_controller.go 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-3.18    #3724   +/-   ##
===============================================
  Coverage                ?   47.50%           
===============================================
  Files                   ?      236           
  Lines                   ?    19923           
  Branches                ?        0           
===============================================
  Hits                    ?     9465           
  Misses                  ?     9562           
  Partials                ?      896           
Flag Coverage Δ
unittests 47.50% <62.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani JaydipGabani merged commit 5888ace into open-policy-agent:release-3.18 Dec 5, 2024
@JaydipGabani JaydipGabani deleted the release-3.18 branch December 5, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants