ci: fix gator image for ghcr#3700
Merged
Merged
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #3700 +/- ##
==========================================
- Coverage 54.49% 47.72% -6.78%
==========================================
Files 134 236 +102
Lines 12329 19846 +7517
==========================================
+ Hits 6719 9471 +2752
- Misses 5116 9485 +4369
- Partials 494 890 +396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| $(if $(filter true,$(PUSH_TO_GHCR)),-t $(GHCR_REPOSITORY):$(VERSION)) . | ||
|
|
||
| docker-buildx-release: docker-buildx-builder | ||
| docker-buildx-crds-dev: build-crds docker-buildx-builder |
Contributor
There was a problem hiding this comment.
Nit: This rule is getting swapped with docker-buildx-release and vice versa without any change.
Member
Author
There was a problem hiding this comment.
yea i just shuffled the makefile so it goes dev -> release for each image
JaydipGabani
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: