feat: Add commonLabels to Deployments#3684
Merged
ritazh merged 9 commits intoNov 13, 2024
Merged
Conversation
Signed-off-by: Anlan Du <adu47249@gmail.com> Co-authored-by: alex <8968914+acpana@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Wyatt Fry <wyattfry@gmail.com>
Signed-off-by: Wyatt Fry <wyattfry@gmail.com>
wyattfry
force-pushed
the
add-common-labels-on-deploys
branch
from
a2a2687 to
42611e7
Compare
wyattfry
changed the title
Signed-off-by: Wyatt Fry <wyattfry@gmail.com>
…ttfry/gatekeeper into add-common-labels-on-deploys
Signed-off-by: Wyatt Fry <wyattfry@gmail.com>
Contributor
Author
|
@JaydipGabani @maxsmythe @ritazh @abhipatnala Could I please have a review? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3684 +/- ##
==========================================
- Coverage 54.49% 47.56% -6.93%
==========================================
Files 134 236 +102
Lines 12329 19786 +7457
==========================================
+ Hits 6719 9412 +2693
- Misses 5116 9488 +4372
- Partials 494 886 +392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaydipGabani
approved these changes
Nov 13, 2024
Contributor
JaydipGabani
left a comment
JaydipGabani
left a comment
There was a problem hiding this comment.
@wyattfry applologies for delay. LGTM. Thanks for the PR!
sozercan
approved these changes
Nov 13, 2024
ritazh
approved these changes
Nov 13, 2024
Contributor
|
@open-policy-agent/gatekeeper-maintainers PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This adds Kubernetes-recommended labels to the Deployment manifests. https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
Which issue(s) this PR fixes: No corresponding issue
Special notes for your reviewer: The labels were present on the Pods but not on the Deployments themselves. I tried my best to add the labels in a way that is consistent with the precedent set by the existing code, but I've never worked on a generated chart like this, so I may have made some rookie mistakes. If there's a cleaner way I'm completely open to it.