fix: helm warning when setting NetworkPolicy ingress rule(s)#3541
Merged
Conversation
Signed-off-by: Sebastian Stephan <sebastian@stephan.li>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3541 +/- ##
==========================================
- Coverage 54.49% 47.99% -6.50%
==========================================
Files 134 218 +84
Lines 12329 15167 +2838
==========================================
+ Hits 6719 7280 +561
- Misses 5116 7070 +1954
- Partials 494 817 +323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaydipGabani
approved these changes
Sep 12, 2024
Contributor
JaydipGabani
left a comment
There was a problem hiding this comment.
Thanks for the PR! lgtm
ritazh
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When setting custom ingress rules for the NetworkPolicy via
controllerManager.networkPolicy.ingress, helm spits out a warning, because the default value is set to{ }instead of an array.Example Values:
Helm Warning:
This fixes it by setting the default value to an empty array.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: