fix: vap error logging for rego only templates#3520
Merged
JaydipGabani merged 2 commits intoSep 4, 2024
Conversation
Signed-off-by: martijnvdp <m.vanderploeg@nl.ccv.eu>
martijnvdp
force-pushed
the
fix-vap-error-logging
branch
from
1f8840c to
3ff7238
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3520 +/- ##
==========================================
- Coverage 54.49% 47.97% -6.53%
==========================================
Files 134 219 +85
Lines 12329 15169 +2840
==========================================
+ Hits 6719 7277 +558
- Misses 5116 7074 +1958
- Partials 494 818 +324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ritazh
approved these changes
Sep 2, 2024
Member
ritazh
left a comment
ritazh
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the PR @martijnvdp!
Member
|
@JaydipGabani please cherrypick this to 3.17 and cut a release for v3.17.1 |
JaydipGabani
approved these changes
Sep 4, 2024
JaydipGabani
added a commit
to JaydipGabani/gatekeeper
that referenced
this pull request
Sep 4, 2024
Signed-off-by: martijnvdp <m.vanderploeg@nl.ccv.eu> Co-authored-by: Jaydipkumar Arvindbhai Gabani <gabanijaydip@gmail.com> (cherry picked from commit 7429d70)
JaydipGabani
added a commit
to JaydipGabani/gatekeeper
that referenced
this pull request
Sep 4, 2024
Signed-off-by: martijnvdp <m.vanderploeg@nl.ccv.eu> Co-authored-by: Jaydipkumar Arvindbhai Gabani <gabanijaydip@gmail.com> (cherry picked from commit 7429d70) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
JaydipGabani
added a commit
that referenced
this pull request
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
currently logging vap generation errors on rego only templates, this pr changes the
oroperator toandto exclude the ErrCodeNotDefined errorWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3516
Special notes for your reviewer: