fix: podLabels template conversion error on deployment templates#2986
Closed
fmorgad0 wants to merge 3 commits into
Closed
fix: podLabels template conversion error on deployment templates#2986fmorgad0 wants to merge 3 commits into
fmorgad0 wants to merge 3 commits into
Conversation
fmorgad0
force-pushed
the
podlabels-template-fix
branch
2 times, most recently
from
6a3a500 to
bad0853
Compare
ritazh
reviewed
Sep 13, 2023
ritazh
reviewed
Sep 14, 2023
fmorgad0
force-pushed
the
podlabels-template-fix
branch
2 times, most recently
from
dfe4a96 to
d0371ee
Compare
Signed-off-by: fmorgad0 <filipe.morgado@talkdesk.com>
fmorgad0
force-pushed
the
podlabels-template-fix
branch
from
d0371ee to
d90f176
Compare
Contributor
|
@fmorgad0 Please push the changes after running |
Author
|
Closing this PR as it has already been merged in #3153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix for podLabels template rendering issue for gatekeeper-audit-deployment and gatekeeper-controller-manager-deployment
Special notes for your reviewer:
Present issue after adding
podLabelswith dummy values on values.yaml and trying to rendering the template: