Skip to content

chore: configure retries in pre-upgrade hook job (helm) #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sozercan merged 2 commits into from
Apr 28, 2023
Merged

chore: configure retries in pre-upgrade hook job (helm) #2710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2ae27e
chore: configure retries in pre-upgrade hook job (helm)
aramase Apr 19, 2023
c1d3084
Merge branch 'master' into aramase/i/2685
sozercan Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/build/helmify/static/templates/upgrade-crds-hook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ metadata:
helm.sh/hook-weight: "1"
helm.sh/hook-delete-policy: "hook-succeeded,before-hook-creation"
spec:
backoffLimit: 0
backoffLimit: 3
template:
metadata:
name: gatekeeper-update-crds-hook
Expand Down
2 changes: 1 addition & 1 deletion manifest_staging/charts/gatekeeper/templates/upgrade-crds-hook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ metadata:
helm.sh/hook-weight: "1"
helm.sh/hook-delete-policy: "hook-succeeded,before-hook-creation"
spec:
backoffLimit: 0
backoffLimit: 3
Copy link
Copy Markdown
Contributor

@acpana acpana Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not take the default? something less to configure?

Copy link
Copy Markdown
Contributor Author

@aramase aramase Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is 6 and retries are with exponential backoff (I've mentioned this in the PR description as well) which could cause the job to hang for longer in case of actual failures. The goal with configuring it to 3 was so there are some retries but still we could fail fast. Let me know what you think!

template:
metadata:
name: gatekeeper-update-crds-hook
Expand Down