Skip to content

chore: Upgrade CF for multi-engine#2616

Merged
maxsmythe merged 3 commits into
open-policy-agent:masterfrom
maxsmythe:upgrade-cf-multi-eng
Mar 8, 2023
Merged

chore: Upgrade CF for multi-engine#2616
maxsmythe merged 3 commits into
open-policy-agent:masterfrom
maxsmythe:upgrade-cf-multi-eng

Conversation

@maxsmythe
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds multi-engine support to Gatekeeper in anticipation of the CEL KEP:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/3488-cel-admission-control

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe maxsmythe force-pushed the upgrade-cf-multi-eng branch from 5a5913f to 76f990d Compare March 6, 2023 23:41
Signed-off-by: Max Smythe <smythe@google.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (2c2bc3b) 53.56% compared to head (76f990d) 53.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2616      +/-   ##
==========================================
+ Coverage   53.56%   53.62%   +0.06%     
==========================================
  Files         120      120              
  Lines       10634    10634              
==========================================
+ Hits         5696     5703       +7     
+ Misses       4505     4500       -5     
+ Partials      433      431       -2     
Flag Coverage Δ
unittests 53.62% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/gator/test/test.go 61.90% <100.00%> (ø)
pkg/webhook/policy.go 38.73% <100.00%> (ø)
...onstrainttemplate/constrainttemplate_controller.go 56.93% <0.00%> (+1.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxsmythe maxsmythe requested review from ritazh and sozercan March 7, 2023 00:02
Copy link
Copy Markdown
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Copy link
Copy Markdown
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit 2f4e4f3 into open-policy-agent:master Mar 8, 2023
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 23, 2023
Signed-off-by: Max Smythe <smythe@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants