feat: implement expansion template pod status by davis-haba · Pull Request #2598 · open-policy-agent/gatekeeper

davis-haba · 2023-02-23T20:15:14Z

Signed-off-by: davis-haba davishaba@google.com

Implements byPod status for ExpansionTemplates.

maxsmythe

Directionally, this is looking really good. Have a few nit comments (and it looks like this may still be WIP)

JaydipGabani · 2023-03-01T23:03:42Z

@davis-haba I'd really appreciate if you can explain what is the need behind this PR. As I have not looked at how expansion templates work I do not have enough background. So I am a little confused and curious.

maxsmythe · 2023-03-02T01:30:50Z

Davis can probably give better context, but it's similar to the reasoning behind constraint/constrainttemplate/mutator statuses (make the ingestion state of a config across the fleet of pods visible)

codecov-commenter · 2023-03-04T01:19:10Z

Codecov Report

Patch coverage: 39.52% and project coverage change: -0.42 ⚠️

Comparison is base (143e8cf) 53.27% compared to head (c03e842) 52.85%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2598      +/-   ##
==========================================
- Coverage   53.27%   52.85%   -0.42%     
==========================================
  Files         120      123       +3     
  Lines       10594    10926     +332     
==========================================
+ Hits         5644     5775     +131     
- Misses       4515     4695     +180     
- Partials      435      456      +21

Flag	Coverage Δ
unittests	`52.85% <39.52%> (-0.42%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
apis/status/v1beta1/zz_generated.deepcopy.go	`0.00% <0.00%> (ø)`
pkg/webhook/policy.go	`37.76% <0.00%> (-1.32%)`	⬇️
...status/v1beta1/expansiontemplatepodstatus_types.go	`8.69% <8.69%> (ø)`
apis/status/v1beta1/util.go	`76.31% <25.00%> (ø)`
pkg/controller/expansion/stats_reporter.go	`54.05% <45.83%> (ø)`
pkg/controller/expansion/expansion_controller.go	`55.47% <61.22%> (ø)`
pkg/readiness/ready_tracker.go	`69.19% <65.30%> (-0.46%)`	⬇️
apis/status/v1beta1/constraintpodstatus_types.go	`80.64% <100.00%> (ø)`
...tatus/v1beta1/constrainttemplatepodstatus_types.go	`73.91% <100.00%> (ø)`
apis/status/v1beta1/mutatorpodstatus_types.go	`80.00% <100.00%> (ø)`
... and 2 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

davis-haba · 2023-03-10T07:19:23Z

@JaydipGabani

@davis-haba I'd really appreciate if you can explain what is the need behind this PR. As I have not looked at how expansion templates work I do not have enough background. So I am a little confused and curious.

The byPod status, present on Constraints, Mutators, and now ExpansionTemplates, is designed to report the status of each resource as observed by each Pod.

For example, suppose you have 3 validation webhook replicas. You might be interested in guaranteeing that all 3 of the replicas have all of the necessary ExpansionTemplates or Constraints registered. If only 2/3 of them have a config registered, this could lead to under-enforcement or nondeterministic behavior.

The design doc has much more detail if you're interested.

Signed-off-by: davis-haba <davishaba@google.com>

maxsmythe

Code LGTM barring a nit. Waiting on testing TODOs otherwise.

Signed-off-by: davis-haba <davishaba@google.com>

maxsmythe

LGTM

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>

davis-haba · 2023-03-31T00:05:59Z

@ritazh
I accepted your comment suggestions (thanks btw).

Was there anything else to address?

ritazh

LGTM

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>

Signed-off-by: davis-haba <davishaba@google.com>

Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>

davis-haba changed the title ~~implement expansion template pod status~~ [feat] implement expansion template pod status Feb 23, 2023

maxsmythe reviewed Feb 25, 2023

View reviewed changes

davis-haba changed the title ~~[feat] implement expansion template pod status~~ feat: implement expansion template pod status Mar 3, 2023

davis-haba added 8 commits March 23, 2023 16:17

implement expansion template pod status

5920c95

Signed-off-by: davis-haba <davishaba@google.com>

appease linter, fix tests

3587840

Signed-off-by: davis-haba <davishaba@google.com>

gofumpt et status controller

6bf3fab

Signed-off-by: davis-haba <davishaba@google.com>

controller tests

14ce870

Signed-off-by: davis-haba <davishaba@google.com>

address comments

d1a8fae

Signed-off-by: davis-haba <davishaba@google.com>

remove dead code

70d76d3

Signed-off-by: davis-haba <davishaba@google.com>

fix expansion tests

97c3727

Signed-off-by: davis-haba <davishaba@google.com>

readiness test for expansion

1dc7a4c

Signed-off-by: davis-haba <davishaba@google.com>

davis-haba force-pushed the expansion-status branch from 43e7312 to 1dc7a4c Compare March 23, 2023 23:17

maxsmythe reviewed Mar 24, 2023

View reviewed changes

Comment thread apis/expansion/unversioned/expansiontemplate_types.go Outdated

maxsmythe reviewed Mar 24, 2023

View reviewed changes

Comment thread test/bats/test.bats Outdated

maxsmythe reviewed Mar 24, 2023

View reviewed changes

davis-haba added 3 commits March 23, 2023 18:31

cleanup tests

85b5e6c

Signed-off-by: davis-haba <davishaba@google.com>

fix linter

51a3cec

Signed-off-by: davis-haba <davishaba@google.com>

fix helm kustomization for expansion status

b2196b7

Signed-off-by: davis-haba <davishaba@google.com>

davis-haba force-pushed the expansion-status branch from d6e2abc to b2196b7 Compare March 24, 2023 01:57

maxsmythe reviewed Mar 24, 2023

View reviewed changes

Comment thread cmd/build/helmify/kustomization.yaml

davis-haba added 3 commits March 23, 2023 19:06

add byPod json annotation to ExpansionTEmplateStatus.ByPod

e3dfede

Signed-off-by: davis-haba <davishaba@google.com>

revert auto indent

4f44f81

Signed-off-by: davis-haba <davishaba@google.com>

fix kustomize

50d6127

Signed-off-by: davis-haba <davishaba@google.com>

maxsmythe approved these changes Mar 24, 2023

View reviewed changes

maxsmythe requested review from ritazh and sozercan March 24, 2023 21:22

Merge branch 'master' into expansion-status

cf895f2

ritazh reviewed Mar 27, 2023

View reviewed changes

Comment thread apis/expansion/unversioned/expansiontemplate_types.go Outdated

ritazh reviewed Mar 27, 2023

View reviewed changes

Comment thread apis/status/v1beta1/expansiontemplatepodstatus_types.go Outdated

ritazh reviewed Mar 27, 2023

View reviewed changes

Comment thread apis/status/v1beta1/expansiontemplatepodstatus_types.go Outdated

davis-haba and others added 3 commits March 27, 2023 13:57

Update apis/status/v1beta1/expansiontemplatepodstatus_types.go

f5a7567

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>

Update apis/expansion/unversioned/expansiontemplate_types.go

95754ee

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>

Update apis/status/v1beta1/expansiontemplatepodstatus_types.go

80b2608

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>

ritazh approved these changes Apr 3, 2023

View reviewed changes

Merge branch 'master' into expansion-status

82e00fd

ritazh reviewed Apr 3, 2023

View reviewed changes

Comment thread apis/expansion/v1alpha1/expansiontemplate_types.go Outdated

ritazh reviewed Apr 3, 2023

View reviewed changes

Comment thread config/crd/bases/expansion.gatekeeper.sh_expansiontemplate.yaml Outdated

davis-haba and others added 3 commits April 4, 2023 17:03

Update apis/expansion/v1alpha1/expansiontemplate_types.go

4edaeb5

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>

make manifests

35fe404

Signed-off-by: davis-haba <davishaba@google.com>

Merge branch 'master' into expansion-status

c03e842

davis-haba merged commit 7c519b4 into open-policy-agent:master Apr 5, 2023

nreisch mentioned this pull request Jun 17, 2025

feat: Export Connection CR #3999

Merged

Conversation

davis-haba commented Feb 23, 2023

Uh oh!

maxsmythe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaydipGabani commented Mar 1, 2023

Uh oh!

maxsmythe commented Mar 2, 2023

Uh oh!

codecov-commenter commented Mar 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

davis-haba commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxsmythe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maxsmythe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davis-haba commented Mar 31, 2023

Uh oh!

ritazh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Mar 4, 2023 •

edited

Loading

davis-haba commented Mar 10, 2023 •

edited

Loading