feat: add the errorlint check for golangci-lint#2519
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2519 +/- ##
==========================================
+ Coverage 53.78% 54.09% +0.31%
==========================================
Files 116 116
Lines 10286 10287 +1
==========================================
+ Hits 5532 5565 +33
+ Misses 4324 4301 -23
+ Partials 430 421 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sozercan
approved these changes
Jan 17, 2023
Member
sozercan
left a comment
sozercan
left a comment
There was a problem hiding this comment.
Thank you for adding this! LGTM
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
Fish-pro
force-pushed
the
feature/errlint
branch
from
1b2dc9b to
13b93e0
Compare
maxsmythe
approved these changes
Jan 20, 2023
Contributor
maxsmythe
left a comment
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM, thank you for the PR!
ritazh
approved these changes
Jan 21, 2023
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 7, 2023
Add the errorlint check Signed-off-by: Fish-pro <zechun.chen@daocloud.io> Signed-off-by: Fish-pro <zechun.chen@daocloud.io> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fish-pro zechun.chen@daocloud.io
What this PR does / why we need it:
Adds errorlint checks to
golangci-lint, standardizing the error format and error judgmentsWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: