fix: cutpath for ../ paths#2498
Merged
Merged
Conversation
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
acpana
commented
Jan 6, 2023
| // contained in the file var. | ||
| cutPath := strings.TrimPrefix(originalPath, "/") | ||
| cutPath = strings.TrimPrefix(cutPath, "./") | ||
| for strings.HasPrefix(cutPath, "../") { |
Contributor
Author
There was a problem hiding this comment.
i'm not too concerned about an infinite loop here since specifying an arbitrarily large number of prev directories has to happen for that
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2498 +/- ##
==========================================
+ Coverage 53.35% 53.38% +0.02%
==========================================
Files 116 116
Lines 10270 10272 +2
==========================================
+ Hits 5480 5484 +4
+ Misses 4370 4368 -2
Partials 420 420
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Pana 8968914+acpana@users.noreply.github.com
I missed specifying the prev dir relatively in my original cut trick: #2443 and this was raised in #2495. Fixes #2495 .
The issue was the cut didn't work w paths prefixed w
../. Added tests for that now.Also, if you want to see it in action now for these kinds of paths: