fix: high-risk vulnerabilities caused by low version of kustomize#2490
fix: high-risk vulnerabilities caused by low version of kustomize#2490fengshunli wants to merge 3 commits into
Conversation
Codecov ReportBase: 53.32% // Head: 53.18% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2490 +/- ##
==========================================
- Coverage 53.32% 53.18% -0.14%
==========================================
Files 116 116
Lines 10270 10270
==========================================
- Hits 5476 5462 -14
- Misses 4373 4383 +10
- Partials 421 425 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: fsl <1171313930@qq.com>
| - containerPort: {{ .Values.controllerManager.healthPort }} | ||
| name: healthz | ||
| protocol: TCP | ||
| - containerPort: 8443 |
There was a problem hiding this comment.
looks like these are being duplicated
There was a problem hiding this comment.
it is indeed a problem caused by the upgraded version of kustomize
| apiVersion: admissionregistration.k8s.io/v1 | ||
| kind: MutatingWebhookConfiguration | ||
| metadata: | ||
| annotations: {{- toYaml .Values.mutatingWebhookAnnotations | trim | nindent 4 }} |
There was a problem hiding this comment.
run make manifests to automatically delete
There was a problem hiding this comment.
I don't think we would want these to be deleted, we might want to check why new kustomize is deleting them
There was a problem hiding this comment.
it is indeed a problem caused by the upgraded version of kustomize. I first submitted the pr of yq. I solved the problem of kustomize and submitted it with another branch. This is the pr of yq #2497
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| annotations: {{- toYaml .Values.secretAnnotations | trim | nindent 4 }} |
There was a problem hiding this comment.
it is indeed a problem caused by the upgraded version of kustomize
There was a problem hiding this comment.
using version 4 or above, it can be written in such a format, which can solve the problem of missing annotations @sozercan @ ritazh
the generated effect display
reference link https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
fengshunli
changed the title
|
looks like #2518 is a newer pr? @fengshunli please try to work in a single pr so comments don't get lost. I'll close this one for now. |
3 participants
upgrade kustomize
upgrade yq