fix(helm): allow installation of post-install and post-upgrade jobs#2351
Merged
sozercan merged 2 commits intoOct 22, 2022
Merged
Conversation
518df90 to
f5a2997
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2351 +/- ##
==========================================
- Coverage 53.32% 53.27% -0.05%
==========================================
Files 116 116
Lines 10198 10198
==========================================
- Hits 5438 5433 -5
- Misses 4342 4345 +3
- Partials 418 420 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Was missing from 52db6a7 Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr>
f5a2997 to
eb9a40d
Compare
maxsmythe
approved these changes
Oct 22, 2022
Contributor
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was missing from 52db6a7