Skip to content

fix(helm): allow installation of post-install and post-upgrade jobs#2351

Merged
sozercan merged 2 commits into
open-policy-agent:masterfrom
sathieu:restricted_postInstallWebhookProbeContainer
Oct 22, 2022
Merged

fix(helm): allow installation of post-install and post-upgrade jobs#2351
sozercan merged 2 commits into
open-policy-agent:masterfrom
sathieu:restricted_postInstallWebhookProbeContainer

Conversation

@sathieu
Copy link
Copy Markdown
Contributor

@sathieu sathieu commented Oct 21, 2022

Error creating: pods "gatekeeper-update-namespace-label-abcde" is forbidden:
  violates PodSecurity "restricted:v1.24":
    seccompProfile (pod or container "webhook-probe-post"
      must set securityContext.seccompProfile.type
      to "RuntimeDefault" or "Localhost")

Was missing from 52db6a7

@sathieu sathieu force-pushed the restricted_postInstallWebhookProbeContainer branch from 518df90 to f5a2997 Compare October 21, 2022 10:37
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 21, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.27%. Comparing base (684f05a) to head (715bffb).
Report is 783 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2351      +/-   ##
==========================================
- Coverage   53.32%   53.27%   -0.05%     
==========================================
  Files         116      116              
  Lines       10198    10198              
==========================================
- Hits         5438     5433       -5     
- Misses       4342     4345       +3     
- Partials      418      420       +2     
Flag Coverage Δ
unittests 53.27% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Was missing from 52db6a7

Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr>
@sathieu sathieu force-pushed the restricted_postInstallWebhookProbeContainer branch from f5a2997 to eb9a40d Compare October 21, 2022 11:13
Copy link
Copy Markdown
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Copy link
Copy Markdown
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@sozercan sozercan merged commit 2193ad9 into open-policy-agent:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants