feat: Promote mutation to v1#2305
Conversation
Signed-off-by: Max Smythe <smythe@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2305 +/- ##
==========================================
+ Coverage 53.41% 53.44% +0.03%
==========================================
Files 116 116
Lines 10174 10174
==========================================
+ Hits 5434 5438 +4
+ Misses 4320 4318 -2
+ Partials 420 418 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return c.Watch( | ||
| &source.Kind{Type: &mutationsv1beta1.AssignMetadata{}}, | ||
| handler.EnqueueRequestsFromMapFunc(util.EventPackerMapFuncHardcodeGVK(schema.GroupVersionKind{Group: v1beta1.MutationsGroup, Version: "v1beta1", Kind: "AssignMetadata"})), | ||
| &source.Kind{Type: &mutationsv1.ModifySet{}}, |
|
do we want to update the docs in a seperate pr? |
|
looks like there were some v1beta1 references remaining, do we want to update these? |
There's value in not updating them: it helps ensure we haven't broken the use of v1beta1 mutators (which will likely be supported indefinitely) |
Yeah, that makes sense. Do we need to worry about timing? I'm guessing the staging workflow will sort that out? |
|
re: docs, we can do it anytime |
4 participants
Promotes mutation to v1 as part of designating it GA
Signed-off-by: Max Smythe smythe@google.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #2296
Special notes for your reviewer: