feat: Add metric reporting to ExpansionTemplate controller#2276
Merged
davis-haba merged 4 commits intoSep 29, 2022
Conversation
Signed-off-by: davis-haba <davishaba@google.com>
Codecov ReportBase: 53.36% // Head: 53.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2276 +/- ##
==========================================
- Coverage 53.36% 53.35% -0.01%
==========================================
Files 116 116
Lines 10161 10161
==========================================
- Hits 5422 5421 -1
- Misses 4319 4320 +1
Partials 420 420
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
maxsmythe
approved these changes
Sep 22, 2022
Contributor
maxsmythe
left a comment
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this!
Signed-off-by: davis-haba <davishaba@google.com>
ritazh
reviewed
Sep 28, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: davis-haba davishaba@google.com
What this PR does / why we need it:
Adds metric reporting to the ExpansionTemplate Controller. The controller will simply report a count of the number of ExpansionTemplates on the cluster.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: