Skip to content

fix: Change 'securityContext/capabilities/drop' from 'all' to 'ALL'.#2273

Merged
ritazh merged 3 commits into
open-policy-agent:masterfrom
boatmisser:fix/helm-chart-capabilities-case
Sep 20, 2022
Merged

fix: Change 'securityContext/capabilities/drop' from 'all' to 'ALL'.#2273
ritazh merged 3 commits into
open-policy-agent:masterfrom
boatmisser:fix/helm-chart-capabilities-case

Conversation

@boatmisser
Copy link
Copy Markdown
Contributor

Signed-off-by: Chris Burke christopher.burke@airnz.co.nz

What this PR does / why we need it:
The helm chart default values used the incorrect case for securityContext.capabilities.drop.
Was:

  securityContext:
    capabilities:
      drop:
        - all

Now:

  securityContext:
    capabilities:
      drop:
        - ALL

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #2271

Special notes for your reviewer:

Signed-off-by: Chris Burke <christopher.burke@airnz.co.nz>
@sozercan
Copy link
Copy Markdown
Member

sozercan commented Sep 19, 2022

@boatmisser thanks for the PR! Can you run make manifests and push the changes please?
https://open-policy-agent.github.io/gatekeeper/website/docs/help/#contributing-to-helm-chart

Signed-off-by: Chris Burke <christopher.burke@airnz.co.nz>
@boatmisser
Copy link
Copy Markdown
Contributor Author

@sozercan
Sorry, my bad, I interpreted that guide as those changes would be "clobbered when we do a new release"; so while I ran make manifests to check the results I did not add them to the commit.

Have now pushed make manifests changes, thanks!

Copy link
Copy Markdown
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 20, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.33%. Comparing base (01e2d53) to head (9efd24e).
Report is 816 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2273      +/-   ##
==========================================
- Coverage   53.35%   53.33%   -0.02%     
==========================================
  Files         115      115              
  Lines       10131    10131              
==========================================
- Hits         5405     5403       -2     
- Misses       4309     4311       +2     
  Partials      417      417              
Flag Coverage Δ
unittests 53.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ritazh ritazh merged commit 600a68d into open-policy-agent:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default helm values violate restricted security level due to case.

4 participants