Skip to content

fix: helm upgrade test#2263

Merged
sozercan merged 3 commits into
open-policy-agent:masterfrom
sozercan:helm-upgrade-k8s
Sep 14, 2022
Merged

fix: helm upgrade test#2263
sozercan merged 3 commits into
open-policy-agent:masterfrom
sozercan:helm-upgrade-k8s

Conversation

@sozercan
Copy link
Copy Markdown
Member

@sozercan sozercan commented Sep 14, 2022

Signed-off-by: Sertac Ozercan sozercan@gmail.com

What this PR does / why we need it:
Helm upgrade test is currently broken since we are trying to deploy an old chart to Kubernetes v1.25 which doesn't have PSP and PDB API versions from the chart

Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: [unable to recognize "": no matches for kind "PodSecurityPolicy" in version "policy/v1beta1", unable to recognize "": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"]
https://github.com/open-policy-agent/gatekeeper/actions/runs/3055615332/jobs/4928863170

Once GK v3.10.0 is out, we can update base chart to v3.10.0 if we want to test on Kubernetes v1.25. For now, downgrading to Kubernetes 1.24.4 to unblock this test.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.54%. Comparing base (08a6263) to head (c230e01).
Report is 834 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2263      +/-   ##
==========================================
+ Coverage   54.49%   54.54%   +0.04%     
==========================================
  Files         111      111              
  Lines        9556     9556              
==========================================
+ Hits         5208     5212       +4     
+ Misses       3947     3944       -3     
+ Partials      401      400       -1     
Flag Coverage Δ
unittests 54.54% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
This reverts commit 13d5d1d.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan merged commit 2bc00bc into open-policy-agent:master Sep 14, 2022
@sozercan sozercan deleted the helm-upgrade-k8s branch September 14, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants