fix: skip empty k8s resources#2247
Merged
Merged
Conversation
maxsmythe
approved these changes
Aug 26, 2022
Contributor
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix!
Codecov Report
@@ Coverage Diff @@
## master #2247 +/- ##
==========================================
- Coverage 54.57% 54.55% -0.03%
==========================================
Files 111 111
Lines 9554 9556 +2
==========================================
- Hits 5214 5213 -1
+ Misses 3946 3943 -3
- Partials 394 400 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Marko Grgic <marko.grgic@qaware.de>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While using the Gator CLI (v3.9.0) to test helm rendered k8s resources against our Gatekeeper constraints we ran into the following error:
auditing objects: adding data of GVK "/, Kind=": admission.k8s.gatekeeper.sh: invalid request object: resource has no versionAfter investigation we found out that the error was due to a input file like the following one:
Apparently Gator CLI attempts to parse above snippet as 3 seperate YAML documents, looking for k8s resources inside them, which won't work as the second one containing only the comment cannot be parsed into a valid k8s resource at all.
This PR suggests skipping empty k8s resources.