feat(helm): Allow configuration of probe timeouts in Helm Chart#2220
Merged
sozercan merged 3 commits intoAug 12, 2022
Conversation
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
|
Hi, does someone have a bit of time to review this? Would be super useful. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2220 +/- ##
==========================================
+ Coverage 54.33% 54.53% +0.20%
==========================================
Files 111 111
Lines 9538 9538
==========================================
+ Hits 5182 5202 +20
+ Misses 3956 3941 -15
+ Partials 400 395 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
ethanrange
force-pushed
the
chart_probe_timeouts
branch
from
27205b2 to
5f54806
Compare
Contributor
Author
|
Not sure what exactly is breaking the linter - Update: Confirmed linter passes locally |
maxsmythe
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Aug 17, 2022
…-policy-agent#2220) * feat(helm): Allow configuration of probe timeouts in Helm Chart Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com> * Fix whitepace in replacements.go Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com> Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ethan Range 65268454+ethanrange@users.noreply.github.com
What this PR does / why we need it: This PR allows for the timeouts for the Readiness and Liveness probes for the Gatekeeper controller and auditor to be adjusted through the Helm Chart.
Special notes for your reviewer:
N/A