fix(helm): explicitly specify curl in probeWebhook#2207
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2207 +/- ##
==========================================
+ Coverage 54.33% 54.42% +0.08%
==========================================
Files 111 111
Lines 9529 9529
==========================================
+ Hits 5178 5186 +8
+ Misses 3952 3946 -6
+ Partials 399 397 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sozercan
approved these changes
Jul 29, 2022
Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add
curlas first argument of probeWebhook container, so it's possible to use different images which do have curl but don't havecurlset as an entrypoint.this is exactly what entrypoint of curlimages/curl does: it adds
curlif first argument is not a valid command:https://github.com/curl/curl-docker/blob/28034fa450ec24aa79cb17fe65b00eda85ae3e2c/alpine/latest/entrypoint.sh#L10-L12