Skip to content

fix(helm): explicitly specify curl in probeWebhook#2207

Merged
sozercan merged 1 commit into
open-policy-agent:masterfrom
stek29:helmcurl
Jul 31, 2022
Merged

fix(helm): explicitly specify curl in probeWebhook#2207
sozercan merged 1 commit into
open-policy-agent:masterfrom
stek29:helmcurl

Conversation

@stek29
Copy link
Copy Markdown
Contributor

@stek29 stek29 commented Jul 29, 2022

What this PR does / why we need it:
Add curl as first argument of probeWebhook container, so it's possible to use different images which do have curl but don't have curl set as an entrypoint.

this is exactly what entrypoint of curlimages/curl does: it adds curl if first argument is not a valid command:
https://github.com/curl/curl-docker/blob/28034fa450ec24aa79cb17fe65b00eda85ae3e2c/alpine/latest/entrypoint.sh#L10-L12

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #2207 (6a440b4) into master (46547db) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2207      +/-   ##
==========================================
+ Coverage   54.33%   54.42%   +0.08%     
==========================================
  Files         111      111              
  Lines        9529     9529              
==========================================
+ Hits         5178     5186       +8     
+ Misses       3952     3946       -6     
+ Partials      399      397       -2     
Flag Coverage Δ
unittests 54.42% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/readiness/object_tracker.go 82.91% <0.00%> (-1.07%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 56.59% <0.00%> (+1.67%) ⬆️
pkg/watch/replay.go 81.25% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46547db...6a440b4. Read the comment docs.

Copy link
Copy Markdown
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants