Skip to content

fix: chart always use v1beta1 as pdb api version#2164

Merged
sozercan merged 4 commits into
open-policy-agent:masterfrom
max0ne:patch-1
Jul 16, 2022
Merged

fix: chart always use v1beta1 as pdb api version#2164
sozercan merged 4 commits into
open-policy-agent:masterfrom
max0ne:patch-1

Conversation

@max0ne
Copy link
Copy Markdown
Contributor

@max0ne max0ne commented Jul 13, 2022

Capabilities.APIVersions only contains <api group>/<version>, it doesn't include kinds

@sozercan
Copy link
Copy Markdown
Member

@max0ne Thanks for the PR! Helm chart is auto-generated in Gatekeeper, and these changes will get clobbered when we do a new release. Please see contributing changes for modifying helm chart: master/charts/gatekeeper#contributing-changes

Copy link
Copy Markdown
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Signed-off-by: Mingfei Huang <mingfei.huang@getcruise.com>
@max0ne
Copy link
Copy Markdown
Contributor Author

max0ne commented Jul 14, 2022

@sozercan thanks, updated

@sozercan
Copy link
Copy Markdown
Member

@max0ne thanks! can you run make manifests and push the changes?

Signed-off-by: Mingfei Huang <mingfei.huang@getcruise.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #2164 (fd211b5) into master (3323c81) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2164      +/-   ##
==========================================
- Coverage   54.40%   54.34%   -0.06%     
==========================================
  Files         111      111              
  Lines        9529     9529              
==========================================
- Hits         5184     5179       -5     
- Misses       3948     3951       +3     
- Partials      397      399       +2     
Flag Coverage Δ
unittests 54.34% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/readiness/list.go 79.41% <0.00%> (-11.77%) ⬇️
pkg/readiness/ready_tracker.go 69.83% <0.00%> (-0.51%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 56.11% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f1e0b...fd211b5. Read the comment docs.

Copy link
Copy Markdown
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sozercan sozercan requested a review from maxsmythe July 15, 2022 21:49
Copy link
Copy Markdown
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 26abae5 into open-policy-agent:master Jul 16, 2022
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Jul 19, 2022
)

Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Jul 19, 2022
)

Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: davis-haba <davishaba@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants