Skip to content

fix: make audit more fault tolerant, log error instead of skipping update #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ritazh merged 1 commit into from
Jul 14, 2022
Merged

fix: make audit more fault tolerant, log error instead of skipping update #2162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions pkg/audit/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,26 +488,25 @@ func (am *Manager) reviewObjects(ctx context.Context, kind string, folderCount i

files, err := am.getFilesFromDir(pDir, int(*auditChunkSize))
if err != nil {
errs = append(errs, err)
am.log.Error(err, "Unable to get files from directory")
continue
}
for _, fileName := range files {
contents, err := os.ReadFile(path.Join(pDir, fileName)) // #nosec G304
if err != nil {
errs = append(errs, err)
am.log.Error(err, "Unable to get content from file", "fileName", fileName)
continue
}
objFile, err := am.readUnstructured(contents)
if err != nil {
errs = append(errs, err)
am.log.Error(err, "Unable to get unstructured data from content in file", "fileName", fileName)
continue
}
objNs := objFile.GetNamespace()
ns := corev1.Namespace{}
if objNs != "" {
ns, err = nsCache.Get(ctx, am.client, objNs)
if err != nil {
errs = append(errs, err)
am.log.Error(err, "Unable to look up object namespace", "objNs", objNs)
continue
}
Expand All @@ -518,7 +517,7 @@ func (am *Manager) reviewObjects(ctx context.Context, kind string, folderCount i
}
resp, err := am.opa.Review(ctx, augmentedObj)
if err != nil {
errs = append(errs, err)
am.log.Error(err, "Unable to review object from file", "fileName", fileName, "objNs", objNs)
continue
}

Expand Down