Skip to content

fix: sed on specific tag in make release-manifest#2153

Merged
sozercan merged 1 commit into
open-policy-agent:masterfrom
chewong:fix-sed-release-manifest
Jul 6, 2022
Merged

fix: sed on specific tag in make release-manifest#2153
sozercan merged 1 commit into
open-policy-agent:masterfrom
chewong:fix-sed-release-manifest

Conversation

@chewong
Copy link
Copy Markdown
Member

@chewong chewong commented Jul 6, 2022

What this PR does / why we need it:

Fixes a bug in the release process where it accidentally bumped the tag of the curl image.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: GitHub <noreply@github.com>
@chewong chewong requested a review from sozercan July 6, 2022 22:20
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 6, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.39%. Comparing base (f1bbd65) to head (f853932).
Report is 888 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2153      +/-   ##
==========================================
+ Coverage   54.35%   54.39%   +0.04%     
==========================================
  Files         111      111              
  Lines        9530     9530              
==========================================
+ Hits         5180     5184       +4     
+ Misses       3951     3949       -2     
+ Partials      399      397       -2     
Flag Coverage Δ
unittests 54.39% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 9924843 into open-policy-agent:master Jul 6, 2022
sozercan pushed a commit that referenced this pull request Jul 6, 2022
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Jul 11, 2022
@chewong chewong deleted the fix-sed-release-manifest branch July 11, 2022 22:24
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Jul 19, 2022
…t#2153)

Signed-off-by: davis-haba <davishaba@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants