fix: Set spec.hard.pod value to string#1928
Merged
Merged
Conversation
Member
|
@OpenSourceZombie thanks for the PR! This is auto-generated. Can you revert your current change and make changes in: gatekeeper/config/manager/manager.yaml Line 198 in 1f8b3ea then run Looks like DCO needs to be signed and needs a semantic pr title too. |
Contributor
|
Also, this will get clobbered by the config autogen process unless it also gets updated here: gatekeeper/config/manager/manager.yaml Lines 191 to 204 in cdd14e0 |
Signed-off-by: ahmed <ahmed@planet.com>
Signed-off-by: ahmed <ahmed@planet.com>
Contributor
Author
|
@sozercan - updated and signed my commits. |
maxsmythe
approved these changes
Jul 20, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes v3.7.1 on k8s 1.20 with server side apply
Special notes for your reviewer:
When deploying v3.7.1 using deploy/gatekeeper.yaml with server side apply I get
From the examples here https://kubernetes.io/docs/concepts/policy/resource-quotas/#resource-quota-per-priorityclass this value should be a string not an integer