Add name to match criteria#1542
Merged
julianKatz merged 17 commits intoSep 17, 2021
Merged
Conversation
Signed-off-by: juliankatz <juliankatz@google.com>
Signed-off-by: juliankatz <juliankatz@google.com>
Signed-off-by: juliankatz <juliankatz@google.com>
Signed-off-by: juliankatz <juliankatz@google.com>
… add-name-to-match-criteria-1402 Signed-off-by: juliankatz <juliankatz@google.com>
In open-policy-agent#1402, a user sought to modify an object of a specific name. Previously, there was no way to do this. The user attempted to use assignIf against metadata.name, but assignIf only allows a mutation to check against the current value of the field to be mutated. This PR adds exact name matching support, as well as prefix-based glob matching. Contributes to open-policy-agent#1402 Signed-off-by: juliankatz <juliankatz@google.com>
julianKatz
requested review from
maxsmythe,
ritazh,
shomron,
sozercan and
willbeason
Codecov Report
@@ Coverage Diff @@
## master #1542 +/- ##
==========================================
- Coverage 52.35% 52.12% -0.24%
==========================================
Files 86 86
Lines 7844 7854 +10
==========================================
- Hits 4107 4094 -13
- Misses 3387 3403 +16
- Partials 350 357 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… add-name-to-match-criteria-1402 Signed-off-by: juliankatz <juliankatz@google.com>
willbeason
reviewed
Sep 9, 2021
… add-name-to-match-criteria-1402 Signed-off-by: juliankatz <juliankatz@google.com>
Signed-off-by: juliankatz <juliankatz@google.com>
Signed-off-by: juliankatz <juliankatz@google.com>
Signed-off-by: juliankatz <juliankatz@google.com>
…valid Signed-off-by: juliankatz <juliankatz@google.com>
Signed-off-by: juliankatz <juliankatz@google.com>
willbeason
approved these changes
Sep 10, 2021
Signed-off-by: juliankatz <juliankatz@google.com>
Signed-off-by: juliankatz <juliankatz@google.com>
willbeason
approved these changes
Sep 13, 2021
ritazh
reviewed
Sep 14, 2021
… add-name-to-match-criteria-1402 Signed-off-by: juliankatz <juliankatz@google.com>
julianKatz
force-pushed
the
add-name-to-match-criteria-1402
branch
from
3d00dd1 to
421aa72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1402, a user sought to modify an object of a specific name.
Previously, there was no way to do this. The user attempted to use
assignIf against metadata.name, but assignIf only allows a mutation to
check against the current value of the field to be mutated.
This PR adds exact name matching support, as well as prefix-based glob
matching.
Contributes to #1402
Signed-off-by: juliankatz juliankatz@google.com