feat: Change template annotation to use k8s-style casing#352
Closed
julianKatz wants to merge 1 commit into
Closed
Conversation
In open-policy-agent/gatekeeper#2734 (comment) the decision was made to change the sync data anotation casing from `requiresSyncData` to `requires-sync-data`. This better fits k8s standards. This PR updates gatekeeper-library templates with the new annotation key. Signed-off-by: juliankatz <juliankatz@google.com>
apeabody
reviewed
Jun 9, 2023
Contributor
apeabody
left a comment
apeabody
left a comment
There was a problem hiding this comment.
Thanks @julianKatz! - The CI is asking for a make generate generate-website-docs generate-artifacthub-artifacts - however I suspect that it will block on changing the already released template versions, so we'll probably need to bump the relevant template patch versions and release as new template versions.
| @@ -5,7 +5,7 @@ metadata: | |||
| annotations: | |||
| metadata.gatekeeper.sh/title: "Horizontal Pod Autoscaler" | |||
| metadata.gatekeeper.sh/version: 1.0.0 | |||
Contributor
There was a problem hiding this comment.
Suggested change
| metadata.gatekeeper.sh/version: 1.0.0 | |
| metadata.gatekeeper.sh/version: 1.0.1 |
Contributor
Author
|
I'm going to let @apeabody take the lead here and close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In open-policy-agent/gatekeeper#2734 (comment) the decision was made to change the sync data anotation casing from
requiresSyncDatatorequires-sync-data. This better fits k8s standards.This PR updates gatekeeper-library templates with the new annotation key.