Skip to content

chore: Upgrade to k8s v0.26.1#284

Merged
maxsmythe merged 2 commits into
open-policy-agent:masterfrom
maxsmythe:upgrade-k8s
Feb 1, 2023
Merged

chore: Upgrade to k8s v0.26.1#284
maxsmythe merged 2 commits into
open-policy-agent:masterfrom
maxsmythe:upgrade-k8s

Conversation

@maxsmythe
Copy link
Copy Markdown
Contributor

Signed-off-by: Max Smythe smythe@google.com

Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe maxsmythe requested review from ritazh and sozercan January 28, 2023 02:56
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 49.30% // Head: 49.30% // No change to project coverage 👍

Coverage data is based on head (a68b677) compared to base (5e694bd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   49.30%   49.30%           
=======================================
  Files          69       69           
  Lines        4468     4468           
=======================================
  Hits         2203     2203           
  Misses       2021     2021           
  Partials      244      244           
Flag Coverage Δ
unittests 49.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe
Copy link
Copy Markdown
Contributor Author

@sozercan @ritazh ready for review. For some reason G8r is no longer auto-pulling the yaml file, but adding an import to main.go in G8r should fix that.

@ritazh
Copy link
Copy Markdown
Member

ritazh commented Feb 1, 2023

Re-running gatekeeper_test

unable to install CRDs onto control plane: unable to read CRD files

@ritazh
Copy link
Copy Markdown
Member

ritazh commented Feb 1, 2023

For some reason G8r is no longer auto-pulling the yaml file, but adding an import to main.go in G8r should fix that.

@maxsmythe which yaml file are you referring to?

@maxsmythe
Copy link
Copy Markdown
Contributor Author

@ritazh The YAML that's causing the gatekeeper test to fail:

https://github.com/open-policy-agent/frameworks/blob/master/constraint/deploy/crds.yaml

For some reason the gomod trick of putting the file next to a golang file stopped working with this change, but can be fixed if we import the stub golang file.

Copy link
Copy Markdown
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for fixing this!

@sozercan
Copy link
Copy Markdown
Member

sozercan commented Feb 1, 2023

@sozercan
Copy link
Copy Markdown
Member

sozercan commented Feb 1, 2023

Copy link
Copy Markdown
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged GK PR, rerunning CI. LGTM

@maxsmythe
Copy link
Copy Markdown
Contributor Author

Thanks!

@maxsmythe maxsmythe merged commit 777dc99 into open-policy-agent:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants