Conversation
The background of the photo view does not extend below the height of the viewport, and so the asset details fade in over black with the photo view, and the standard surface colour scheme of the scaffold for the rest. This leads to a janky animation. We can't change the background of the scaffold to black, as it in turn makes the iOS bouncing scroll physics cut off incorrectly. The best fix is to remove background decoration from the photo view, and defer to the parent to colour the background. Co-authored-by: Alex <alex.tran1502@gmail.com>
* feat(mobile): SyncAssetEditV1 * fix: websocket handling * fix: server version requirement * fix: revert pubspec changes
Covers bug fixes (person thumbnail, download-as-album, album cover), quick-rotate in viewer toolbar, and batch rotate in timeline.
Design for phased pet detection feature: - Phase 1: YOLOv8 object detection for animal species - Phase 2: MegaDescriptor embeddings for individual pet recognition - Reuses existing person infrastructure (unified with people) - Opt-in feature, disabled by default Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
10 tasks across 3 phases: bug fixes, quick-rotate, batch rotate.
14-task plan covering Phase 1 (YOLOv8 detection): - ML Python: PetDetector model, schemas, registration, tests - Server: enums, config, DTOs, migration, service, job integration - Web: admin settings, pet badge on people cards - OpenAPI regeneration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Search results use a different provider than the main timeline, and they appear appear to have diverged a bit. This means that assets can sometimes look wrong or different in search compared to the main timeline or albums.
Format plan docs that were failing CI prettier check.
…main # Conflicts: # docs/plans/2026-03-05-image-editing-improvements-design.md # docs/plans/2026-03-05-image-editing-improvements-plan.md # docs/plans/2026-03-05-pet-detection-design.md
Add git credential configuration using github.token before dart pub get to avoid unauthenticated rate limits when fetching git dependencies (native_video_player) on fork CI runners.
This reverts commit 93dec49.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
immich-app/immichmain into our forkTest plan
🤖 Generated with Claude Code