Merged
Conversation
SteveMacenski
approved these changes
Jul 4, 2024
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
Please submit against Nav2 as well!
Are you using Jazzy/Rolling? Might be good to use the Nav2 version over there. This is going to be deprecated in the medium term (hence why duplicate PRs to keep them in sync is important :-) ).
Contributor
Author
|
Done! ros-navigation/navigation2#4522 I'm using humble unfortunately, but thanks for the heads up. |
Signed-off-by: redvinaa <redvinaa@gmail.com>
SteveMacenski
approved these changes
Jul 5, 2024
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At one place in both the dock and undock BT node declarations it's written
error_codeinstead oferror_code_id. This fixes the error codes not getting set in the navigator.