v4.1.x: shmem: fix oshmem_shmem_finalize() when main() returns not zero value.
#9314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue.
Example:
int main(void) {
int rc = 0;
shmem_init();
if (0 == shmem_my_pe())
rc = 1;
shmem_finalize();
return rc;
}
If the user wants to return not-zero status, this leads to
`ompi_mpi_finalize()` won't be called and the program terminates
abnormally.
Signed-off-by: Boris Karasev <[email protected]>
(cherry picked from commit ceb9259)
yosefe
approved these changes
Aug 26, 2021
Contributor
|
Should this go back to v4.0.x as well? |
Member
Author
Yes, will cherry-pick. |
brminich
approved these changes
Aug 30, 2021
Member
|
@jsquyres, ok to merge? |
Member
|
Please properly label and milestone your PRs, otherwise they don't get seen by the release managers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to #9310