v4.1.x: common/ofi: Utilize new libfabric API to import memhooks monitor #9308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch attempts to open up libfabric resources in order to notify libfabric when our memhooks patcher intercepts free calls. Signed-off-by: William Zhang <[email protected]> (cherry picked from commit 25811e2)
Contributor
Author
|
Turns out something was just unclean with my build, spun up new instances to test and it worked fine |
Contributor
Author
|
aws:bot:retest |
hppritcha
approved these changes
Aug 25, 2021
Contributor
Author
|
Previously set this as DNM since we were discussing whether we wanted #9318 , still would like this to get into 4.1.2 |
There are known issues with the API in libfabric 1.13.0 which will guarantee segfaults when used. These issues are fixed in libfabric 1.13.1, but we do not have a way to detect which patch version of libfabric is used. Thus, delay the usage of the API until the subsequent minor release. Signed-off-by: William Zhang <[email protected]> (cherry picked from commit 190feba)
Contributor
Author
|
Repush since the cherry-pick wasn't in master at the time |
Contributor
Author
|
Please help me merge this patch, thanks |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch attempts to open up libfabric resources in order to notify
libfabric when our memhooks patcher intercepts free calls.
Signed-off-by: William Zhang [email protected]
(cherry picked from commit 25811e2)