v4.1.x: fix a memory hook recursion hang #9276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this checkin, it's possible for a stack trace like the following
to occur:
free()
madvise()
intercept_madvise()
opal_mem_hooks_release_hook(), loop of registered callbacks which includes
ompi_mtl_mxm_mem_release_cb()
mxm_mem_unmap(,,from_alloc=false)
...
free()
The problem is since we're already in glibc free() we need to call the
release callback with from_alloc=true so it will take a more conservative
path and only record the memory being released without making any malloc/free
calls.
Signed-off-by: Austen Lauria <[email protected]>
(cherry picked from commit d620ad1)
wckzhang
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this checkin, it's possible for a stack trace like the following
to occur:
free()
madvise()
intercept_madvise()
opal_mem_hooks_release_hook(), loop of registered callbacks which includes
ompi_mtl_mxm_mem_release_cb()
mxm_mem_unmap(,,from_alloc=false)
...
free()
The problem is since we're already in glibc free() we need to call the
release callback with from_alloc=true so it will take a more conservative
path and only record the memory being released without making any malloc/free
calls.
Signed-off-by: Austen Lauria [email protected]
(cherry picked from commit d620ad1)