v4.1.x: orted_comm: Add debugging message to kill procs. #9268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit b76d9ad)
awlauria
changed the title
jjhursey
approved these changes
Aug 17, 2021
gpaulsen
approved these changes
Aug 17, 2021
awlauria
changed the title
jsquyres
reviewed
Aug 29, 2021
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
Can someone provide a little more context for this commit? It looks like it puts an unconditional debug-level output message on stderr whenever the daemon kills local procs. Is that really desirable?
Contributor
|
Only if "--debug-daemons" was provided, so it is protected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Hursey [email protected]
(cherry picked from commit b76d9ad)