v4.0.x: Correctly process 0 slots with -host option. #9221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awlauria
force-pushed
the
fix_host_parse
branch
from
a135574 to
64a7aad
Compare
rhc54
requested changes
Aug 12, 2021
orte/mca/ess/hnp/ess_hnp_module.c
Outdated
| node->name = strdup(orte_process_info.nodename); | ||
| node->index = ORTE_PROC_MY_NAME->vpid; | ||
| node->slots = 0; | ||
| ORTE_FLAG_SET(node, ORTE_NODE_FLAG_SLOTS_GIVEN); |
Contributor
There was a problem hiding this comment.
I don't think you really want to do this - setting that flag means we won't sense the number of available slots by counting the number of cores. So basically you are "locking" mpirun itself to 0 slots. IIRC, the object constructor sets slots to zero - otherwise, this initializer is fine.
Contributor
Author
There was a problem hiding this comment.
Thanks - I think you're right and these lines aren't needed for the patch. Verifying..
awlauria
force-pushed
the
fix_host_parse
branch
from
64a7aad to
21418ee
Compare
The following command: mpirun -host hostA:0,hostB:6 ./x was launching: (num_cores on hostA) + (6 hostB ranks) instead of only the expected 6 ranks on hostB. This works correctly with -hostfile with "hostA slots=0". This patch just makes the behaviors consistent. Co-authored-by: Austen Lauria <[email protected]> Signed-off-by: Austen Lauria <[email protected]>
awlauria
force-pushed
the
fix_host_parse
branch
from
21418ee to
7b6f478
Compare
Contributor
Author
|
bot:aws:retest more java. |
rhc54
approved these changes
Aug 12, 2021
Contributor
|
FWIW: I ported this over to PRRTE |
Contributor
Author
|
@rhc54 thanks! I can port the others as well if you don't have the time to do it. |
Contributor
Contributor
Author
|
Does #9222 apply as well? |
Contributor
No - PRRTE doesn't modify |
Member
|
Does PR #9234 need to be updated? |
Contributor
Author
gpaulsen
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following command:
mpirun -host hostA:0,hostB:6 ./x
was launching: (num_cores on hostA) + (6 hostB ranks)
instead of only the expected 6 ranks on hostB.
This works correctly with -hostfile with "hostA slots=0".
This patch just makes the behaviors consistent.
bot:notacherrypick
Co-authored-by: Austen Lauria [email protected]
Signed-off-by: Austen Lauria [email protected]