osc/rdma: ensure bml add_procs has been called for all local procs #8453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug when ob1 was not selected as the pml but osc/rdma may be selected for an MPI window. In some cases we may use btl/sm. If this is the case we need to ensure btl/sm knows about all the local procs (not just the ones in the communicator). This is required for btl/sm to correctly function at this time. In the future btl/sm should be made more resilient. Fixes open-mpi#8434 Signed-off-by: Nathan Hjelm <hjelmn@google.com> (cherry picked from commit 8040d05)
bosilca
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when ob1 was not selected as the pml but osc/rdma may be
selected for an MPI window. In some cases we may use btl/sm. If this is the
case we need to ensure btl/sm knows about all the local procs (not just the
ones in the communicator). This is required for btl/sm to correctly function
at this time.
In the future btl/sm should be made more resilient.
Fixes #8434
Signed-off-by: Nathan Hjelm hjelmn@google.com
(cherry picked from commit 8040d05)