Skip to content

common/ofi: Use opal_show_help() to call out lack of locality info #8447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsquyres merged 1 commit into from
Feb 8, 2021
Merged

common/ofi: Use opal_show_help() to call out lack of locality info #8447

jsquyres merged 1 commit into from
Feb 8, 2021

Conversation

@rajachan
Copy link
Member

@rajachan rajachan commented Feb 4, 2021 •
edited
Loading 

opal_show_help() can dedup output across ranks when using mpirun. Print
the help text only when the OFI component's verbosity is > 9.

Signed-off-by: Raghu Raja <[email protected]>

@rajachan rajachan added this to the v4.1.1 milestone Feb 4, 2021
@rajachan rajachan requested review from dancejic and jsquyres February 4, 2021 01:09
@rajachan
Copy link
Member Author

rajachan commented Feb 4, 2021

Cherry pick of #8244 that addresses #8236

@rajachan
Copy link
Member Author

rajachan commented Feb 4, 2021

/azp run

Not clear why this change is tripping up Mellanox CI with:

--- MCA component sshmem:verbs (m4 configuration macro)
checking for MCA component sshmem:verbs compile mode... dso
checking if want verbs shared memory support... yes
checking if MCA component sshmem:verbs can compile... no
checking for size of endpoint array... 1
configure: WARNING: No spml found, so OpenSHMEM layer will be non functional.
configure: error: Aborting because OpenSHMEM requested, but can not build.
+ jenkins_cleanup
+ EXIT_CODE=1
+ echo 'Script exited with code = 1'
+ rm -rf /tmp/tmp.ZshPJwO2gY

Trying again.

@open-mpi open-mpi deleted a comment from azure-pipelines bot Feb 4, 2021
@rajachan
Copy link
Member Author

rajachan commented Feb 4, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 4, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@rajachan
Copy link
Member Author

rajachan commented Feb 4, 2021

bot:aws:retest

jsquyres
jsquyres reviewed Feb 4, 2021
View reviewed changes
@rajachan rajachan requested review from a team and removed request for dancejic February 4, 2021 19:39
hppritcha
hppritcha reviewed Feb 5, 2021
View reviewed changes
Copy link
Member

@hppritcha hppritcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather see something like what Jeff suggests

@rajachan rajachan force-pushed the package_rank_help branch 2 times, most recently from b99e8c8 to 4018b76 Compare February 8, 2021 04:28
@rajachan rajachan changed the title common/ofi: fixing error message to be a debug output common/ofi: Use opal_show_help() to call out lack of locality info Feb 8, 2021
@ibm-ompi
Copy link

ibm-ompi commented Feb 8, 2021

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/e7171b21bb64b67fe0cbc33224405a2e

@jjhursey
Copy link
Member

jjhursey commented Feb 8, 2021

IBM Ci had an issue over the weekend. Retrying. bot:ibm:retest

@rajachan
common/ofi: Use opal_show_help() to call out lack of locality info
7e7862e 
opal_show_help() can dedup output across ranks when using mpirun. Print
the help text only when the OFI component's verbosity is >= 10.

Signed-off-by: Raghu Raja <[email protected]>
@jsquyres
Copy link
Member

jsquyres commented Feb 8, 2021

@rajachan Can you put the cherry pick message in the commit message? Thanks!

@jsquyres
Copy link
Member

jsquyres commented Feb 8, 2021

@rajachan Can you put the cherry pick message in the commit message? Thanks!

This is technically not a cherry pick from master; that's why it's not noted that way.

@jsquyres jsquyres merged commit 380ac96 into open-mpi:v4.1.x Feb 8, 2021
@ibm-ompi
Copy link

ibm-ompi commented Feb 8, 2021

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6

@it-is-a-robot it-is-a-robot mentioned this pull request Nov 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsquyres jsquyres jsquyres approved these changes

@hppritcha hppritcha Awaiting requested review from hppritcha

Assignees

No one assigned

Labels

Target: v4.1.x

Projects

None yet

Milestone

v4.1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@rajachan @ibm-ompi @jjhursey @jsquyres @hppritcha