V4.1.x PML/UCX: don't do pml_check_selected call#8405
Merged
jsquyres merged 1 commit intoopen-mpi:v4.1.xfrom Jan 22, 2021
Merged
V4.1.x PML/UCX: don't do pml_check_selected call#8405jsquyres merged 1 commit intoopen-mpi:v4.1.xfrom
jsquyres merged 1 commit intoopen-mpi:v4.1.xfrom
Conversation
Member
|
Commit is not signed off --> this is now fixed Corresponding master PR (#8404) is not merged yet. Reverting back to "Draft" to make sure it's not merged before master PR is merged. |
vspetrov
force-pushed
the
v4.1.x_pml_ucx_check_selected_fix
branch
from
ee2f945 to
99b82f3
Compare
Member
|
@vspetrov clarified: this is (intentionally) not a cherry pick. See discussion on the v4.0.x PR: #8406 (comment) |
vspetrov
force-pushed
the
v4.1.x_pml_ucx_check_selected_fix
branch
from
99b82f3 to
b73ff38
Compare
vspetrov
changed the title
vspetrov
force-pushed
the
v4.1.x_pml_ucx_check_selected_fix
branch
from
b73ff38 to
4f222f7
Compare
Current implementation of pml check protocol causes extra dmodex exchanges that may result in a significant performance degradation for some workloads (corresponds to master 36b64cb) Signed-off-by: Valentin Petrov <valentinp@nvidia.com>
vspetrov
force-pushed
the
v4.1.x_pml_ucx_check_selected_fix
branch
from
4f222f7 to
a15f2b9
Compare
bwbarrett
approved these changes
Jan 21, 2021
yosefe
approved these changes
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V4.1.x of #8404