[4.1.x] orte/orted: enable OPAL's mutli-thread support #8362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch added call to opal_set_using_threads() in orted/main.c, which is to enable OPAL's multi-thread support. This is because orted used multiple threads. Without OPAL's multi-thread support, OPAL_RELEASE will not use atomic operations to update an object's reference count, which will lead to double free. This patch is applied to 4.1.x directly because orte has been removed from the master branch. Signed-off-by: Wei Zhang <wzam@amazon.com>
Contributor
Author
|
address #8360 |
rhc54
approved these changes
Jan 11, 2021
Contributor
Author
|
Note this patch is applied to 4.1.x directly because orte has been removed from the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch added call to opal_set_using_threads() in orted/main.c,
which is to enable OPAL's multi-thread support.
This is because orted used multiple threads.
Without OPAL's multi-thread support, OPAL_RELEASE will not use
atomic operations to update an object's reference count, which
will lead to double free.
This patch is applied to 4.1.x directly because orte has been
removed from the master branch.
Signed-off-by: Wei Zhang wzam@amazon.com