v4.1.x: Fixed uninitialized memory access bug in base64 encoding #8265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Shereda <[email protected]>
Contributor
|
It looks like this can also go into the v4.0.x branch - but is no longer relevant to master. |
Contributor
Author
Right, ok... is it my responsibility to open a separate PR for that branch? i.e., what's the procedure? |
Contributor
|
I think you can just PR it directly to 4.0.x. @gpaulsen ? |
jsquyres
changed the title
Contributor
|
You don't want me to review this as I have nothing to do with that code - this is more @artpol84 |
jsquyres
approved these changes
Dec 7, 2020
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
Mellanox confirmed (out of band) that it works on their machines with PMI-1 and PMI-2.
Contributor
|
@jsquyres can you share who has confirmed? |
Member
|
On the RM call yesterday, @rhc54 said you guys (Nvidia/Mellanox) had confirmed. I didn't ask for a specific name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing base64 encoding had the potential for uninitialized memory access, so I added some conditionals to prevent that.