Skip to content

OSC RDMA: put memory for each process into separate pages [4.1.x] #8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsquyres merged 2 commits into from
Nov 23, 2020
Merged

OSC RDMA: put memory for each process into separate pages [4.1.x] #8238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de354ea
OSC RDMA: put memory of each process into separate pages
devreal Sep 29, 2020
2e1e9dc
OSC RDMA: only touch pages before memory registration, don't fill them
devreal Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ompi/mca/osc/rdma/osc_rdma_component.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
#include "opal/util/argv.h"
#include "opal/util/printf.h"
#include "opal/align.h"
#include "opal/util/sys_limits.h"
#if OPAL_CUDA_SUPPORT
#include "opal/datatype/opal_datatype_cuda.h"
#endif /* OPAL_CUDA_SUPPORT */
Expand Down Expand Up @@ -550,6 +551,7 @@ static int allocate_state_shared (ompi_osc_rdma_module_t *module, void **base, s
ompi_osc_rdma_region_t *state_region;
struct _local_data *temp;
char *data_file;
int page_size = opal_getpagesize();

shared_comm = module->shared_comm;

Expand All @@ -574,6 +576,12 @@ static int allocate_state_shared (ompi_osc_rdma_module_t *module, void **base, s
module->state_offset = state_base = local_rank_array_size + module->region_size;
data_base = state_base + leader_peer_data_size + module->state_size * local_size;

/* ensure proper alignment */
if (MPI_WIN_FLAVOR_ALLOCATE == module->flavor) {
data_base += OPAL_ALIGN_PAD_AMOUNT(data_base, page_size);
size += OPAL_ALIGN_PAD_AMOUNT(size, page_size);
}

do {
temp = calloc (local_size, sizeof (temp[0]));
if (NULL == temp) {
Expand Down Expand Up @@ -642,7 +650,12 @@ static int allocate_state_shared (ompi_osc_rdma_module_t *module, void **base, s
}

if (size && MPI_WIN_FLAVOR_ALLOCATE == module->flavor) {
*base = (void *)((intptr_t) module->segment_base + my_base_offset);
char *baseptr = (char *)((intptr_t) module->segment_base + my_base_offset);
*base = (void *)baseptr;
// touch each page to force allocation on local NUMA node
for (size_t i = 0; i < size; i += page_size) {
baseptr[i] = 0;
}
}

module->rank_array = (ompi_osc_rdma_rank_data_t *) module->segment_base;
Expand Down