Fix preference treatment in coll/base [v4.1.x]#8237
Merged
jsquyres merged 4 commits intoopen-mpi:v4.1.xfrom Nov 20, 2020
Merged
Fix preference treatment in coll/base [v4.1.x]#8237jsquyres merged 4 commits intoopen-mpi:v4.1.xfrom
jsquyres merged 4 commits intoopen-mpi:v4.1.xfrom
Conversation
The selectable list is sorted with lowest to highest priority so the user-defined preferences should be appended to the list. The preference treatment should also maintain the order provided by the user (first item has highest priority) so switch the loop order. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit dd54af9)
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit 09c2f4a)
…e components Also make coll/tuned the default for shared memory communication as coll/sm has shown performance issues that need investigation. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit 971d58c)
This has shown to be more effective in achieving overlap of inter- and intra-node communication and reduces the inital delay before hitting the network. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit 1cdc855)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing HAN with ADAPT I noticed that ADAPT is not selected without jumping through some hoops:
selectablelist (the list is order in ascending priority order) and it should preserve the priority provided by the user (decreasing priority order in theompi_comm_coll_preferenceinfo key).coll/sm,coll/adapt, andcoll/hanand removed references to experimental componentscoll/soloandcoll/sharedBackport of #8220 to v4.1.x
Signed-off-by: Joseph Schuchart schuchart@icl.utk.edu