[v4.1.x] mtl/ofi: Check cq_data_size without querying providers again #8205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the unnecessary call to `fi_getinfo()` when initializing the MTL. `cq_data_size` is a domain attribute that will be available to the MTL from the initial query itself. FI_DIRECTED_RECV is a primary capability that has to be requested for a provider to enable it, so adding that to the initial requirement. The redundant query was also overwriting the contents of the prov object, which already had the include/exclude filtering and multi-NIC logic applied to it. Signed-off-by: Raghu Raja <[email protected]> (cherry picked from commit 6233dea)
rajachan
changed the title
dancejic
approved these changes
Nov 12, 2020
Member
Author
|
I've run tests with this PR, with and without multiple NICs on AWS, and things look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the unnecessary call to
fi_getinfo()wheninitializing the MTL.
cq_data_sizeis a domain attribute that will beavailable to the MTL from the initial query itself. FI_DIRECTED_RECV is
a primary capability that has to be requested for a provider to enable
it, so adding that to the initial requirement. The redundant query was
also overwriting the contents of the prov object, which already had the
include/exclude filtering and multi-NIC logic applied to it.
Signed-off-by: Raghu Raja [email protected]
(cherry picked from commit 6233dea)