v4.1.x: reproducible builds + portability fix #8148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwiedemann
suggested changes
Oct 28, 2020
Contributor
bmwiedemann
left a comment
bmwiedemann
left a comment
There was a problem hiding this comment.
needs one more patch:
orte/tools/orte-info/Makefile.am
- -DOMPI_BUILD_DATE="\"`date`\"" \
+ -DOMPI_BUILD_DATE="\"`$(top_srcdir)/config/getdate.sh`\"" \
jsquyres
force-pushed
the
pr/v4.1.x/reproducible-build
branch
from
819f634 to
bf70a29
Compare
Member
Author
|
This PR will also need the MacOS portability fixes from #8152. |
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Oct 29, 2020
Ported from open-mpi/ompi#8148 and open-mpi/ompi#8152 Signed-off-by: Ralph Castain <[email protected]>
Member
Author
|
bot:ompi:retest |
jsquyres
changed the title
rhc54
approved these changes
Oct 29, 2020
This code was invoked twice. Leave it solely in OPAL_CONFIGURE_SETUP, which is invoked before OPAL_BASIC_SETUP. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 7c36b45)
If defined, use SOURCE_DATE_EPOCH environment variable; make the build Reproducible by forcing timestamps. See https://reproducible-builds.org/docs/source-date-epoch/ for more information. Thanks Bernhard M. Wiedemann for bringing this to our attention. Fixes open-mpi#3759 **NOTE:** This was cherry-picked from master, and slightly modified / amended for the v4.1.x branch. Signed-off-by: Gilles Gouaillardet <[email protected]> Signed-off-by: Bernhard M. Wiedemann <[email protected]> Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 7b4e8ba)
MacOS does not have "readlink -f" or "realpath", so use the MacOS-provided Python, which we know has os.path.realpath(). Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit ddf216b)
There are several different flavors of date(1) out there. Try a few different CLI options for date(1) to see which one works. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 89920ba)
jsquyres
force-pushed
the
pr/v4.1.x/reproducible-build
branch
from
9070ca8 to
e7f829b
Compare
rhc54
added a commit
to rhc54/prrte
that referenced
this pull request
Oct 29, 2020
Ported from open-mpi/ompi#8148 and open-mpi/ompi#8152 Signed-off-by: Ralph Castain <[email protected]>
Member
Author
|
@bmwiedemann If the v4.0.x and v4.1.x PRs now test properly for you, I'll merge them. |
bmwiedemann
approved these changes
Nov 1, 2020
Contributor
|
I successfully tested the 4.0.x one, and the code 4.1.x code looks similar enough for me to have a good confidence in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #8136 and #8152 from master regarding reproducible builds. Thanks to @bmwiedemann for bringing this back to our attention.
Also bring in a MacOS/
readlinkportability fix.