oshmem/mca/sshmem: Fix build with --enable-mem-debug#8107
Merged
jsquyres merged 1 commit intoopen-mpi:masterfrom Oct 20, 2020
Merged
oshmem/mca/sshmem: Fix build with --enable-mem-debug#8107jsquyres merged 1 commit intoopen-mpi:masterfrom
--enable-mem-debug#8107jsquyres merged 1 commit intoopen-mpi:masterfrom
Conversation
`--enable-mem-debug` `#define`s `realloc`/`free` as macros, though macros are also matched if they appear in references to members. Rename the members to avoid this matching. See open-mpi#6995 Signed-off-by: Bert Wesarg <bert.wesarg@tu-dresden.de>
awlauria
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--enable-mem-debug#definesrealloc/freeas macros, though macrosare also matched if they appear in references to members. Rename the
members to avoid this matching.
See #6995
Signed-off-by: Bert Wesarg bert.wesarg@tu-dresden.de
This PR replaces #7926. There was a problem with CI on that PR, and we can't easily re-run the signed-off-checker without pushing new commits to the PR. I don't seem to have write perms to @bertwesarg's branch on that fork, so there doesn't seem to be an easy way to do this before @bertwesarg returns from vacation. In the spirit of "let's get this over with", I'm just creating a new PR with the same commit from #7926. 😉