v4.0.x: orterun.1in: fix minor mistake in :PE=2 example and add more descriptions/explanations#8099
Merged
gpaulsen merged 3 commits intoopen-mpi:v4.0.xfrom Nov 9, 2020
Conversation
Member
Author
|
@rhc54 If this is correct, I'll make a PR to cherry-pick this to the v4.1.x branch. |
rhc54
reviewed
Oct 17, 2020
Contributor
|
Can one of the admins verify this patch? |
Member
jsquyres
force-pushed
the
pr/v4.0.x/fix-minor-mistake-in-mpirun.1in
branch
from
24d6149 to
4cc3649
Compare
Member
Author
|
@rhc54 Per our phone conversation, I updated the text. I actually made 3 separate commits that you may want to look at individually:
|
jsquyres
changed the title
jsquyres
changed the title
Fix mistake in orterun(1) (i.e., mpirun(1)) with an example using the :PE=x modifier. Additionally, add some extra text with some further explanation. This is not a cherry-pick from master because PRRTE has replaced ORTE on master, and orterun.1in no longer exists in master. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
force-pushed
the
pr/v4.0.x/fix-minor-mistake-in-mpirun.1in
branch
from
4cc3649 to
2aeb796
Compare
rhc54
reviewed
Nov 9, 2020
Member
|
Note: We need to make sure to sync the language in this PR with the PRRTE version being developed (I'll do that - just dropping a note to link the two) |
added 2 commits
November 9, 2020 10:55
Add descriptive definitions of "slot" and "processor element" at the top of the man page (and effectively delete / move some text from lower in the man page up into those definitions). Also add a little blurb in the --use-hwthread-cpus description about how it changes the definition of "processor element". This is not a cherry-pick from master because PRRTE has replaced ORTE on master, and orterun.1in no longer exists in master. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Add some nroff markup into the paragraph, just to clearly delineate the option names from the paragraph text. No other content changes. This is not a cherry-pick from master because PRRTE has replaced ORTE on master, and orterun.1in no longer exists in master. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
force-pushed
the
pr/v4.0.x/fix-minor-mistake-in-mpirun.1in
branch
from
2aeb796 to
25f84be
Compare
rhc54
approved these changes
Nov 9, 2020
This was referenced Nov 9, 2020
v4.1.x: orterun.1in: fix minor mistake in :PE=2 example and add more descriptions/explanations
#8192
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit messages for detail
These are not cherry-picks from master because PRRTE has replaced ORTE on master, and orterun.1in no longer exists in master.
Refs #7717