Shmem: rename realloc/free in segment_allocator to avoid name clash with memory debugging#7927
Closed
devreal wants to merge 1 commit intoopen-mpi:masterfrom
Closed
Shmem: rename realloc/free in segment_allocator to avoid name clash with memory debugging#7927devreal wants to merge 1 commit intoopen-mpi:masterfrom
devreal wants to merge 1 commit intoopen-mpi:masterfrom
Conversation
…ith memory debugging Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
Member
|
@devreal could you figure out why the jenkins build fails. I clicked everything through but could not found any error. |
Contributor
Author
|
Mhh, not sure why that fails. In the logs I see: |
Member
|
That's a weird one. Let's see if it was a transient error. bot:aws:retest |
Contributor
Author
|
Thanks @jsquyres, tests seem to have succeeded. |
Contributor
Author
|
@yosefe Could you please review this one? |
Contributor
|
We hit this recently and applied a similar fix. Thanks for pushing it upstream. |
awlauria
approved these changes
Oct 7, 2020
Contributor
|
Unlikely as it may be, we could also prepend these with |
Member
|
@bertwesarg @devreal Can you guys figure out which of this PR and #7926 should get merged? They're fairly straightforward and have been sitting around forever. Thanks! |
hoopoepg
approved these changes
Oct 19, 2020
Contributor
|
#7926 merged, so closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tokens
reallocandfreeare overridden by Open MPI's memory debugging facility, leading to build errors if enabled. This PR renames struct members in the shmemsegment_allocatortoreallocateandreleaseto avoid the name clash.Fixes #7925
Signed-off-by: Joseph Schuchart schuchart@hlrs.de